Skip to content

Conversation

@charisk
Copy link
Contributor

@charisk charisk commented Sep 28, 2023

Show modeling status in the method usages panel. See exact spec in the internal linked issue.

image

As part of this I updated modeling store functions to make sure new objects are created when changing the top level properties of the state object. This allows us to continue using object equality to check if updates to the usages panel should happen.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner September 28, 2023 11:37
Copy link
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit 27a7474 into main Sep 28, 2023
@charisk charisk deleted the charisk/method-usages-modeling-status branch September 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants