Merged
Conversation
15d106a to
169a425
Compare
shati-patel
approved these changes
Sep 29, 2023
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
This looks good to me! Works locally, and your explanations for onDidChangeQueries and the disposable make sense.
charisk
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds language filtering to the queries panel. Adding the filtering was trivial, however there were a few other tweaks I had to make.
onDidChangeQueriesthe same asonDidChangePathData. However if we integrated with that it would require a full rescan of the file system to apply a filter which felt quite slow for me. Instead we create a specific emitter foronDidChangeQuerieswhich is triggered by either the filesystem changing or the filter changing.this.languageContext.onLanguageContextChanged. This was because the MockApp created a MockEventEmitter which returned{}as disposable. However{}is actually not disposable (because it lacks the method). So I changed it to return something that is actually disposable.Checklist
ready-for-doc-reviewlabel there.