Skip to content

Use .nvmrc file for setting up Node version in Actions#2902

Merged
koesie10 merged 1 commit intomainfrom
koesie10/actions-nvmrc
Oct 4, 2023
Merged

Use .nvmrc file for setting up Node version in Actions#2902
koesie10 merged 1 commit intomainfrom
koesie10/actions-nvmrc

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Oct 4, 2023

This will make it much easier to change the Node version: you'll only need to make changes to 2 files instead of 6 files.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 4, 2023 08:10
@koesie10 koesie10 requested a review from a team as a code owner October 4, 2023 08:10
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't realise we could do that.

@koesie10 koesie10 merged commit 16af4c4 into main Oct 4, 2023
@koesie10 koesie10 deleted the koesie10/actions-nvmrc branch October 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants