Convert modeled-method-fs.ts to handle multiple models per method#2905
Merged
Convert modeled-method-fs.ts to handle multiple models per method#2905
modeled-method-fs.ts to handle multiple models per method#2905Conversation
This will change the input/output types for modeled methods in the `modeled-method-fs.ts` file to take in multiple models per method. This removes the need for conversion functions between this file and `yaml.ts` files. Instead, the conversion functions are done when calling any functions defined in `modeled-method-fs.ts` files.
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
One comment but otherwise looks good to me.
This is going exactly the way I intended, by pushing the convertToLegacyModeledMethods higher and higher up the call stack, until eventually everything will be converted and we can get rid of those conversion methods. I'm glad it seems to be working out ok.
Co-authored-by: Robert <robertbrignull@github.com>
robertbrignull
approved these changes
Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will change the input/output types for modeled methods in the
modeled-method-fs.tsfile to take in multiple models per method. This removes the need for conversion functions between this file andyaml.tsfiles. Instead, the conversion functions are done when calling any functions defined inmodeled-method-fs.tsfiles.Checklist
ready-for-doc-reviewlabel there.