Skip to content

Use base postMessage instead of webview one#2909

Merged
charisk merged 1 commit intomainfrom
charisk/modeling-view-post-message
Oct 4, 2023
Merged

Use base postMessage instead of webview one#2909
charisk merged 1 commit intomainfrom
charisk/modeling-view-post-message

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Oct 4, 2023

I noticed we were still using this.webviewView.webview.postMessage in a couple of places in the method modeling panel so I fixed that and by doing that a type mismatch was flagged and fixed.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners October 4, 2023 15:44
@charisk charisk merged commit 17947fb into main Oct 4, 2023
@charisk charisk deleted the charisk/modeling-view-post-message branch October 4, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants