Skip to content

Add empty states for modeling panel#2914

Merged
charisk merged 4 commits intomainfrom
charisk/method-modeling-empty-states
Oct 6, 2023
Merged

Add empty states for modeling panel#2914
charisk merged 4 commits intomainfrom
charisk/method-modeling-empty-states

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Oct 5, 2023

Added components for the empty states of the method modeling panel. These are not yet hooked to anything.

As part of this I've introduced a reusable component that I've called "ResponsiveContainer", please let me know if you can think of a better name!

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners October 5, 2023 16:11
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Oct 6, 2023

This is now ready to review. Apologies for the slightly messy commit history. If it's hard to review the PR I can tidy it up a bit - just let me know.

Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charisk charisk merged commit db3d242 into main Oct 6, 2023
@charisk charisk deleted the charisk/method-modeling-empty-states branch October 6, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants