Ensure modified methods updated after changing a method from the modeling panel

[charisk]

Small change to make sure we update the modified methods state when the modeled method gets updated. If we don't do that we can end up in a situation where the state/UI is out of date. For example the following bug exists in the current code:

1. Open model editor
2. Click view on some method
3. Change to source (see it being marked as modeled)
4. Click on another method from the method usages panel
5. Change to flow summary

At this point the second method should be marked as modeled, but it isn't.

Checklist

N/A:

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[starcke]

Looks good, happy to go with this as a bugfix - but I wonder if we can streamline the modeled and modified method calls?

[starcke]

It seems we often have to call addModifiedMethod(s) after methods like updateModeledMethod and addModeledMethods. I wonder if we can move the call to update the modified methods inside the store so that the caller does not have to remember to call both functions?

[charisk]

Yes I'd definitely like to move towards that, it's a good idea. In general I can see a few simplifications/improvements we could make around the modeling store. But I think of this as v1, with a lot of features currently in flux, so I'd rather wait a bit before tidying things up. Basically let it evolve a bit and then come back and address some tech debt once we have a fuller picture of its use.