Conversation
a2a7130 to
c5810fa
Compare
c5810fa to
c668b39
Compare
koesie10
left a comment
There was a problem hiding this comment.
Is it enough to feature flag in package.json so that the panel is never shown or do we need to do it in extension.ts as well?
This should be enough, the extension.ts doesn't really have any way of controlling whether a panel is shown or not.
I could also have read the languageContext in the
getTreeItemmethod instead of passing inselected. However I wasnt sure how often it would callgetTreeItemand it seemed a bit nicer to just set it on construction, but I am happy to change it.
I think this is fine, another alternative would be to construct the tree items in getChildren, but I don't think that has any advantages over this approach either.
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
|
Addressed comments. |
koesie10
left a comment
There was a problem hiding this comment.
Just some small stylistic comments, but the code in general looks good.
Co-authored-by: Koen Vlaswinkel <koesie10@users.noreply.github.com>
This adds a language selection panel to the extension. This hooks into the filtering, so that selecting an item in the panel filters to that language.
This is the first time I added a new panel so I am quite unsure whether it is done in the right way, feedback is very welcome.
Few notes:
package.jsonso that the panel is never shown or do we need to do it inextension.tsas well?getTreeItemmethod instead of passing inselected. However I wasnt sure how often it would callgetTreeItemand it seemed a bit nicer to just set it on construction, but I am happy to change it.Checklist
ready-for-doc-reviewlabel there.