Add CommonFromViewMessages to FromModelEditorMessage

[robertbrignull]

Not sure how we didn't notice this until now but it seems the FromModelEditorMessage type doesn't include CommonFromViewMessages. This means it doesn't include messages for telemetry or errors.

However the view could still send those messages, and they would trigger the assertNever and cause an error. Probably every bit of telemetry was triggering this, but we didn't notice.

Checklist

• CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
• Issues have been created for any UI or other user-facing changes made by this pull request.
• [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

[koesie10]

Thanks for catching this! Do you know why there was no unhandled error for receiving telemetry?

[robertbrignull]

Do you know why there was no unhandled error for receiving telemetry?

As far as I can tell, there isn't any telemetry sent directly from the model editor view. Instead we're emitting the telemetry from the host, such as when handling the hideModeledMethods message we emit model-editor-hide-modeled-methods.

I discovered this because of hitting an unhandled error in the view.