Convert SetSelectedMethodMessage to include multiple modeled methods#2947
Convert SetSelectedMethodMessage to include multiple modeled methods#2947
SetSelectedMethodMessage to include multiple modeled methods#2947Conversation
|
|
||
| interface SetMultipleModeledMethodsMessage { | ||
| t: "setMultipleModeledMethods"; | ||
| modeledMethods: ModeledMethod[]; |
There was a problem hiding this comment.
Did we discuss including methodSignature: string; in this message, so you don't have to work out the signature by looking at the modeled methods?
That would also make it easier to remove all modeled methods for a method signature, instead of having to set it to the array containing one element with type: "none".
I'm happy for you to make this change in this PR or I can do it in a followup, because I'll be using this message in my next PR.
There was a problem hiding this comment.
It does make sense to add it here. Right now, this message is only used for communication from the extension host to the view, but we'll definitely need the signature for the communication from the view to the extension host. I'll change the message now so that I can also use it in a follow-up PR (after #2924).
robertbrignull
left a comment
There was a problem hiding this comment.
Thanks for updating and adding methodSignatures.
Has conflicts, but otherwise LGTM
…elected-method-message
This converts the
SetSelectedMethodMessageto include multiple methods. It also adds a new message to replicate theSetModeledMethodMessagewith multiple modeled methods so that all state is now pushed through correctly from the modeled method view provider. Unfortunately, the nameSetModeledMethodsMessageis already taken by the modeled methods map, so I've created a new messageSetMultipleModeledMethodsMessage. We may want to consider changing these once all messages are properly renamed.The changes to
canMethodBeModeledare directly copied from https://github.com/github/vscode-codeql/pull/2942/files#diff-fb5d586d735e8d18fcae2a4225ba24aff4416e9423ea1a4fb1af7bc5d5805da8Checklist
ready-for-doc-reviewlabel there.