Skip to content

Use SetMultipleModeledMethodsMessage in modeled methods panel#2957

Merged
koesie10 merged 1 commit intomainfrom
koesie10/modeled-methods-panel-multiple-save
Oct 13, 2023
Merged

Use SetMultipleModeledMethodsMessage in modeled methods panel#2957
koesie10 merged 1 commit intomainfrom
koesie10/modeled-methods-panel-multiple-save

Conversation

@koesie10
Copy link
Copy Markdown
Member

This makes the modeled methods panel send the SetMultipleModeledMethodsMessage message when the modeled methods change. This is the last step in wiring up the modeled methods panel; after this has been merged, it is possible to view, edit and save multiple models in the method modeling panel.

The only remaining usage of convertToLegacyModeledMethod is in the ModeledMethodsPanel when the feature flag is disabled. In this case, we're using a different code path, but once the feature flag is removed, it should be possible to remove convertToLegacyModeledMethod.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 12, 2023 09:07
@koesie10 koesie10 requested review from a team as code owners October 12, 2023 09:07
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koesie10 koesie10 merged commit 3c50571 into main Oct 13, 2023
@koesie10 koesie10 deleted the koesie10/modeled-methods-panel-multiple-save branch October 13, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants