Move in-progress methods state to modeling store#2971
Merged
Conversation
koesie10
reviewed
Oct 13, 2023
| } | ||
|
|
||
| interface InProgressMethodsChangedEvent { | ||
| dbUri: string; |
Member
There was a problem hiding this comment.
Is there a specific reason for using dbUri here instead of isActiveDb like some other events?
Contributor
Author
There was a problem hiding this comment.
Yeah I think it lets the model editor view decide whether the event is appropriate for it or not. We do have dbUri in some other events too.
koesie10
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state is currently in the React view but we need it in the modeling store so that it can be used by the method modeling panel too.
Checklist
N/A:
ready-for-doc-reviewlabel there.