Fix decoding source map with VS Code internal files#2987
Merged
Conversation
This makes it possible to decode source maps containing references to code that is not part of the extension. If it finds any such references, it will simply not decode the source map and use the original stack trace instead.
charisk
approved these changes
Oct 17, 2023
| } | ||
| } | ||
|
|
||
| const sourceMap = rawSourceMaps.get(file) as RawSourceMap | null; |
Contributor
There was a problem hiding this comment.
I don't think we need the casting.
Suggested change
| const sourceMap = rawSourceMaps.get(file) as RawSourceMap | null; | |
| const sourceMap = rawSourceMaps.get(file); |
Member
Author
There was a problem hiding this comment.
Thanks! I think this will change the type slightly (since sourceMap can then also be undefined), but that shouldn't matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to decode source maps containing references to code that is not part of the extension. If it finds any such references, it will simply not decode the source map and use the original stack trace instead.
Example stack trace:
Decoded:
Checklist
ready-for-doc-reviewlabel there.