Skip to content

Add higlight on modeled method row when clicking in validation error#3001

Merged
koesie10 merged 2 commits intomainfrom
koesie10/validation-errors-focus
Oct 23, 2023
Merged

Add higlight on modeled method row when clicking in validation error#3001
koesie10 merged 2 commits intomainfrom
koesie10/validation-errors-focus

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds back the clickable link in the validation error alert. When clicking on e.g. "Modify or remove the duplicated classification.", the problematic row will be highlighted. This uses a very similar method to the focusing using revealedMethodRow.

I think the name DataGridRow for this component is still accurate, so I don't think renaming it will make it clearer how this is used.

Screenshot 2023-10-20 at 11 40 35

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review October 20, 2023 10:04
@koesie10 koesie10 requested a review from a team as a code owner October 20, 2023 10:04
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that's simpler than I was expecting it to be. I'm glad there's no need for passing in Ref objects, since everything is happening within one component.

@koesie10 koesie10 merged commit c62c054 into main Oct 23, 2023
@koesie10 koesie10 deleted the koesie10/validation-errors-focus branch October 23, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants