Show stack for redactable error in log#3004
Merged
Conversation
When calling for example `showAndLogExceptionWithTelemetry`, the stack trace would be sent to Application Insights, but there was no way to see the stack trace from within VS Code. This will add the stack trace to the log by returning it from `fullMessageWithStack` and using it in the appropriate places.
koesie10
commented
Oct 20, 2023
| const error = result.message | ||
| ? redactableError`${result.message}` | ||
| : redactableError`Failed to run query`; | ||
| void extLogger.log(error.fullMessage); |
Member
Author
There was a problem hiding this comment.
This was removed because it results in duplicate logs: the showAndLogExceptionWithTelemetry will also log it to the extLogger.
charisk
approved these changes
Oct 23, 2023
Contributor
charisk
left a comment
charisk
left a comment
There was a problem hiding this comment.
Thanks for tidying that up!
| return this.fullMessage; | ||
| } | ||
|
|
||
| return `${this.fullMessage}\n${this.stack}`; |
Contributor
There was a problem hiding this comment.
Should we use os.EOL rather than \n?
Member
Author
There was a problem hiding this comment.
Unfortunately we can't use that because the errors.ts module is also imported from the webview which doesn't have access to os.EOL. I'm not sure whether \n works in VS Code's log output, but I don't think it's worth the complexity of trying to determine whether we're in the webview and then deciding to use either os.EOL or \n.
This reverts commit b33b5bb. The errors module is also imported in the webview, so we can't actually use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling for example
showAndLogExceptionWithTelemetry, the stack trace would be sent to Application Insights, but there was no way to see the stack trace from within VS Code. This will add the stack trace to the log by returning it fromfullMessageWithStackand using it in the appropriate places.Checklist
ready-for-doc-reviewlabel there.