Add method modeling flow to test plan#3010
Conversation
norascheuch
force-pushed
the
nora/modeling-flow-testplan
branch
from
9b9ec12 to
7bade3e
Compare
|
I wonder how many of these checks should be mandatory, what can be optional. |
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
Thanks for adding this! Multiple models are still feature-flagged right now, but since it is going to be removed soon, it's probably fine to not mention that here.
I'm not sure whether these should be optional or not. It's probably good to test them when we have made any changes to them, but don't need to test them when we've only made changes to unrelated code.
| - add a couple of new models for one method | ||
| - save and check that the modeling file (use the 'open extension pack' button to open it) shows multiple methods | ||
| - check that a 'duplicated classification' error appears in both model editor and modeling panel when a duplicate modeling occurs | ||
| - check that a 'conflicting classigication' error appears when a neutral model type is paired with a source kind |
There was a problem hiding this comment.
Neutral models aren't conflicting with source kinds only, they are conflicting with models that have the same type as the neutral model's kind. What about:
| - check that a 'conflicting classigication' error appears when a neutral model type is paired with a source kind | |
| - check that a 'conflicting classification' error appears when a neutral model type is paired with a model of the same kind |
| - check that clicking on the error highlights the correct modeling in both the editor and the modeling panel | ||
| 3. Check the Method Usage | ||
| - Check that the Method Usage Panel opens and jumps to the correct usage when clicking on 'View' in the model editor | ||
| - Check that the usages are opening when clicking on a usage |
There was a problem hiding this comment.
We had a bug here where the first one would show correctly, but clicking on any other ones would still only show the first one. Would it make sense to change this to something like:
| - Check that the usages are opening when clicking on a usage | |
| - Check that the second and third usages show when clicking on them |
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
I agree with Koen's points. But other than that looks good to me
|
I implemented Koens suggestions and also moved most test cases to optional. In the mandatory testing we now only check that both Panels exist, show the first usage (usage panel) and show and update modeling (modeling panel). |
norascheuch
force-pushed
the
nora/modeling-flow-testplan
branch
from
793667a to
807ac4a
Compare
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
There's a tiny linter error, but otherwise the changes LGTM
Thanks for moving stuff into "optional". I think that's the right move for these extra tests of the model editor.
| ### Selecting repositories to run on | ||
| ### Modeling Flow | ||
|
|
||
| 2. Check that a method can have multiple models: |
There was a problem hiding this comment.
The linter has spotted this needs to start with 1, though I believe it won't actually affect the rendering it'll be nice to be consistent.
norascheuch
force-pushed
the
nora/modeling-flow-testplan
branch
from
807ac4a to
0e53067
Compare
3 participants
This PR adds checks for manually testing the new method modeling flow to our release test plan.
Checklist
ready-for-doc-reviewlabel there.