Use the same logic for hiding methods in model editor and usages panel #3014
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that the model editor and the usages panel are using the same logic when deciding whether to show or hide a method.
Before this PR, you wouldn't be able to view usages of any methods that were already modeled and the modeling had been saved. We previously thought this bug only applied when you had modelings coming from an external pack, but you can reproduce it within one pack too.
Steps to reproduce:
With this PR, the usages panel and the model editor are fully in sync and show the same methods and clicking "View" always highlights the method in the usages panel.
Checklist
ready-for-doc-reviewlabel there.