Skip to content

Conversation

@robertbrignull
Copy link
Contributor

Makes sure that the model editor and the usages panel are using the same logic when deciding whether to show or hide a method.

Before this PR, you wouldn't be able to view usages of any methods that were already modeled and the modeling had been saved. We previously thought this bug only applied when you had modelings coming from an external pack, but you can reproduce it within one pack too.

Steps to reproduce:

  • Add a modeling to a method
  • Save the extension pack
  • Click "View" on the modeled method and observe that nothing happens

With this PR, the usages panel and the model editor are fully in sync and show the same methods and clicking "View" always highlights the method in the usages panel.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team as a code owner October 24, 2023 15:25
@robertbrignull robertbrignull force-pushed the robertbrignull/hidden_methods branch from 64e4f26 to 675e2ec Compare October 24, 2023 15:35
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robertbrignull robertbrignull merged commit 2ebccd5 into main Oct 25, 2023
@robertbrignull robertbrignull deleted the robertbrignull/hidden_methods branch October 25, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants