Improve database download prompt when creating query#3016
Conversation
This changes the skeleton query wizard to not prompt for database download after creating a query by default. Instead, it will show a message with a button to download a database which will launch the same prompt.
There was a problem hiding this comment.
Thanks for this! A couple of comments from me. I also agree that the notifications are a bit wordy, but I don't have much inspiration for other options 😅
@jf205, do you have any opinions about the notification wording now that you can see them "in action"? 📝
| const openFileArgs = [ | ||
| join(this.qlPackStoragePath, this.folderName, this.fileName), | ||
| ]; | ||
| const queryString = encodeURI(JSON.stringify(openFileArgs)); | ||
| return `[${this.fileName}](command:vscode.open?${queryString})`; |
There was a problem hiding this comment.
I can't open the file from this link. I haven't looked into debugging this myself yet (happy to help if need be!) but definitely looks like a windows path issue 😅
There was a problem hiding this comment.
I've tried using a URI to fix this. Let me know if it doesn't work, then we can pair on getting it to work on Windows.
There was a problem hiding this comment.
Works for me now! Thanks ✨
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Thanks for the edits! Looks good 🤩
2 participants
This improves the database download prompt when creating a query by removing it from the default flow. Instead, the user will get a notification with information on how they can download a database. There are 3 scenarios:
No notification
I'm very open to suggestions on how to better phrase these notifications, they are currently a bit wordy and repetitive.
Checklist
ready-for-doc-reviewlabel there.