Skip to content

Differentiate between suggestions and accepted models#3059

Merged
charisk merged 3 commits intomainfrom
charisk/accepted-models
Nov 10, 2023
Merged

Differentiate between suggestions and accepted models#3059
charisk merged 3 commits intomainfrom
charisk/accepted-models

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Nov 7, 2023

There are two commits in this PR:

  • 0d3e626 is doing a bunch of prop drilling so that the various input drop-downs have the modeling status available to them.
  • 0078093 adds some logic that allows us to differentiate between models that were suggested by automodel but not necessarily accepted/committed, and ones that have.

This is not perfect as only changes to the Type change provenance at the moment. I'm chasing up to find if that's correct.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner November 7, 2023 10:29
@charisk charisk changed the title Charisk/accepted models Differentiate between suggestions and accepted models Nov 7, 2023
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Nov 9, 2023

The provenance questions are coming to a conclusion and I'd rather have a separate PR to cover that, so I think this PR is ready to be reviewed.

@charisk charisk force-pushed the charisk/accepted-models branch from 5130ae8 to 0078093 Compare November 10, 2023 09:34
@charisk charisk force-pushed the charisk/accepted-models branch from 0078093 to 6de96b4 Compare November 10, 2023 09:35
@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Nov 10, 2023

Thanks for the review @koesie10! I had to make a small change after rebasing from main: 6de96b4

Comment thread extensions/ql-vscode/src/model-editor/modeled-method.ts
@charisk charisk merged commit 28994b7 into main Nov 10, 2023
@charisk charisk deleted the charisk/accepted-models branch November 10, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants