Allow downloading multiple databases from GitHub#3073
Merged
Conversation
koesie10
force-pushed
the
koesie10/download-github-database
branch
from
b190c35 to
636f8f1
Compare
This adds the option to download multiple databases from GitHub in the initial GitHub database download prompt. The databases will be downloaded concurrently. Unfortunately it doesn't seem possible to change the "OK" text in the quick pick to "Download", so I've left it as "OK" for now.
koesie10
force-pushed
the
koesie10/download-multiple-github-databases
branch
from
c20f0d9 to
d0488dd
Compare
3 tasks
…tiple-github-databases
starcke
approved these changes
Nov 21, 2023
Contributor
starcke
left a comment
starcke
left a comment
There was a problem hiding this comment.
Looks good to me. Just a single question/comment.
| selectedDatabases.map((database) => | ||
| withProgress( | ||
| async (progress) => { | ||
| await downloadGitHubDatabaseFromUrl( |
Contributor
There was a problem hiding this comment.
I found it slightly janky that it keeps selecting a new db when it has finished downloading. So when I download several
DBs I feel like I should be able to start immediately with the fastest one, but I dont think it is a big problem.
Member
Author
There was a problem hiding this comment.
I think it's hard to do that since the selection is not controlled by this function itself. It sounds sound like a good idea, but maybe we can see if there's any feedback about this from users and implement something else based on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the option to download multiple databases from GitHub in the initial GitHub database download prompt. The databases will be downloaded concurrently.
Unfortunately it doesn't seem possible to change the "OK" text in the quick pick to "Download", so I've left it as "OK" for now.
Checklist
ready-for-doc-reviewlabel there.