Create separate types for raw results sets#3093
Merged
Conversation
robertbrignull
approved these changes
Dec 12, 2023
Contributor
robertbrignull
left a comment
There was a problem hiding this comment.
There's a lot of code changes in this PR, so I haven't been able to go over ever line in high detail, but I've taken a quick look through all the commits and new files and over the general approach. I've also done a very quick test of running some local queries, comparing results, etc...
The changes look good to me. It does have some conflicts that'll need to be resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates types for raw result sets which are separate from BQRS types. BQRS types are defined by the CodeQL CLI, while these types can be changed by us. The BQRS types are only used in places where the BQRS is directly used.
It's easiest to review this commit-by-commit. The first 3 commits are the largest commits since they touch a lot of code. All follow-up commits are much smaller.
Checklist
ready-for-doc-reviewlabel there.