Skip to content

Create separate types for raw results sets#3093

Merged
koesie10 merged 13 commits intomainfrom
koesie10/separate-bqrs-types
Dec 13, 2023
Merged

Create separate types for raw results sets#3093
koesie10 merged 13 commits intomainfrom
koesie10/separate-bqrs-types

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 27, 2023

This creates types for raw result sets which are separate from BQRS types. BQRS types are defined by the CodeQL CLI, while these types can be changed by us. The BQRS types are only used in places where the BQRS is directly used.

It's easiest to review this commit-by-commit. The first 3 commits are the largest commits since they touch a lot of code. All follow-up commits are much smaller.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review November 27, 2023 13:50
@koesie10 koesie10 requested review from a team as code owners November 27, 2023 13:50
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of code changes in this PR, so I haven't been able to go over ever line in high detail, but I've taken a quick look through all the commits and new files and over the general approach. I've also done a very quick test of running some local queries, comparing results, etc...

The changes look good to me. It does have some conflicts that'll need to be resolved.

@koesie10 koesie10 merged commit 4bb25a7 into main Dec 13, 2023
@koesie10 koesie10 deleted the koesie10/separate-bqrs-types branch December 13, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants