Skip to content

Refactor compare view#3102

Merged
koesie10 merged 6 commits intomainfrom
koesie10/refactor-compare-view
Dec 5, 2023
Merged

Refactor compare view#3102
koesie10 merged 6 commits intomainfrom
koesie10/refactor-compare-view

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Dec 5, 2023

This makes a start on refactoring the compare view to be more maintainable and extensible. The main changes are:

  • Extracting a findResultSetNames function from findCommonResultSetNames
  • Renaming findCommonResultSetNames to findResultSetsToCompare
  • Caching BQRS schemas instead of reading them when changing result sets

It's easiest to review this commit-by-commit.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/refactor-compare-view branch from 6b65119 to 8a9aa06 Compare December 5, 2023 09:40
@koesie10 koesie10 force-pushed the koesie10/refactor-compare-view branch from 8a9aa06 to b1289a4 Compare December 5, 2023 10:02
@koesie10 koesie10 marked this pull request as ready for review December 5, 2023 10:59
@koesie10 koesie10 requested a review from a team as a code owner December 5, 2023 10:59
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the individual commits!

@koesie10 koesie10 merged commit 9c200e0 into main Dec 5, 2023
@koesie10 koesie10 deleted the koesie10/refactor-compare-view branch December 5, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants