Skip to content

Move columns in compare view to result#3103

Merged
koesie10 merged 1 commit intomainfrom
koesie10/compare-view-results
Dec 6, 2023
Merged

Move columns in compare view to result#3103
koesie10 merged 1 commit intomainfrom
koesie10/compare-view-results

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Dec 5, 2023

The columns are part of the result, so they should be moved there. This is in preparation of showing SARIF results in the same view, which don't have columns.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

The columns are part of the result, so they should be moved there. This
is in preparation of showing SARIF results in the same view, which don't
have columns.
@koesie10 koesie10 marked this pull request as ready for review December 6, 2023 08:31
@koesie10 koesie10 requested a review from a team as a code owner December 6, 2023 08:31
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 looks good!

@koesie10 koesie10 merged commit cce8585 into main Dec 6, 2023
@koesie10 koesie10 deleted the koesie10/compare-view-results branch December 6, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants