Skip to content

Extract RawCompareResultTable component#3105

Merged
koesie10 merged 1 commit intomainfrom
koesie10/create-raw-compare-result-table
Dec 6, 2023
Merged

Extract RawCompareResultTable component#3105
koesie10 merged 1 commit intomainfrom
koesie10/create-raw-compare-result-table

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Dec 6, 2023

This extracts part of the CompareTable component to a new RawCompareResultTable to reduce duplication between the from and to columns.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review December 6, 2023 10:05
@koesie10 koesie10 requested a review from a team as a code owner December 6, 2023 10:05
charisk
charisk approved these changes Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@koesie10 koesie10 enabled auto-merge December 6, 2023 10:14
@koesie10 koesie10 merged commit 80081af into main Dec 6, 2023
@koesie10 koesie10 deleted the koesie10/create-raw-compare-result-table branch December 6, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charisk charisk charisk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@koesie10 @charisk