Merged
Conversation
8030e54 to
a7ef07a
Compare
a7ef07a to
9f667ef
Compare
0451b82 to
67ca05e
Compare
67ca05e to
8acff5c
Compare
81cde6b to
8acff5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When building the variant analysis repositories panel we intended to merge local DB functionality with it. Therefore we started writing functionality, types and test for local DB functionality. Since we're not intending to merge both panels anymore this PR removes all mentions of local DB functionality in the VA panel.
What approach did you choose and why?
npm run lintnpm run find-deadcodeChecklist
ready-for-doc-reviewlabel there.