Skip to content

Delete local db functionality#3106

Merged
norascheuch merged 3 commits intomainfrom
nora/remove-local-db-code
Dec 12, 2023
Merged

Delete local db functionality#3106
norascheuch merged 3 commits intomainfrom
nora/remove-local-db-code

Conversation

@norascheuch
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch commented Dec 6, 2023

What are you trying to accomplish?

When building the variant analysis repositories panel we intended to merge local DB functionality with it. Therefore we started writing functionality, types and test for local DB functionality. Since we're not intending to merge both panels anymore this PR removes all mentions of local DB functionality in the VA panel.

What approach did you choose and why?

  • remove skipped tests
  • remove corresponding functionality
  • run and fix npm run lint
  • run and fix npm run find-deadcode
  • do rudimentary manual test (create, rename, delete lists and repos in VA panel and run a MRVA)

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@norascheuch norascheuch force-pushed the nora/remove-local-db-code branch from 8030e54 to a7ef07a Compare December 6, 2023 10:05
@norascheuch norascheuch force-pushed the nora/remove-local-db-code branch from a7ef07a to 9f667ef Compare December 6, 2023 10:18
@norascheuch norascheuch force-pushed the nora/remove-local-db-code branch 2 times, most recently from 0451b82 to 67ca05e Compare December 8, 2023 12:35
@norascheuch norascheuch force-pushed the nora/remove-local-db-code branch from 67ca05e to 8acff5c Compare December 8, 2023 12:42
@norascheuch norascheuch marked this pull request as ready for review December 8, 2023 13:00
@norascheuch norascheuch requested review from a team as code owners December 8, 2023 13:00
@norascheuch norascheuch force-pushed the nora/remove-local-db-code branch from 81cde6b to 8acff5c Compare December 8, 2023 14:08
Copy link
Copy Markdown
Member

@koesie10 koesie10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@norascheuch norascheuch merged commit 6c76218 into main Dec 12, 2023
@norascheuch norascheuch deleted the nora/remove-local-db-code branch December 12, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants