Skip to content

Add interpreted results table to compare view#3112

Merged
koesie10 merged 2 commits intomainfrom
koesie10/compare-sarif-view
Dec 14, 2023
Merged

Add interpreted results table to compare view#3112
koesie10 merged 2 commits intomainfrom
koesie10/compare-sarif-view

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Dec 6, 2023

This adds a InterpretedCompareResultTable component to compare interpreted results in the compare view. It refactors the AlertTable to be reusable between the ResultTable and this new component since these have different headers and no result messages.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/compare-sarif-view branch 3 times, most recently from 2dab45c to c759af1 Compare December 7, 2023 09:22
Base automatically changed from koesie10/compare-raw to main December 7, 2023 09:35
@koesie10 koesie10 force-pushed the koesie10/compare-sarif-view branch from c759af1 to 49114cc Compare December 7, 2023 09:56
@koesie10 koesie10 marked this pull request as ready for review December 7, 2023 09:57
@koesie10 koesie10 requested a review from a team as a code owner December 7, 2023 09:57
@koesie10 koesie10 enabled auto-merge December 14, 2023 09:02
@koesie10 koesie10 merged commit 0415ac5 into main Dec 14, 2023
@koesie10 koesie10 deleted the koesie10/compare-sarif-view branch December 14, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants