Add support for models on types for Ruby#3117
Merged
Conversation
This fixes the rendering of method names when either the type or method name is empty. This can happen when the method is a not in a class or when the method is a synthetic method and the properties actually apply to the type.
This fixes the output of the Ruby MaD models when the method name is empty which can happen when the model applies to a type rather than to a method.
koesie10
force-pushed
the
koesie10/fix-ruby-modules
branch
from
338aeff to
0a4d28e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two bugs that happen when a "method" is actually a type and does not belong to a specific method. This happens in Ruby when specifying subclasses where
Net::HTTPHeader,HTTParty::Response::Headers,in the YAML format means thatHTTParty::Response::Headersinherits fromNet::HTTPHeader. Type models are able to generate this data already, so we should propagate this information.For testing this, you can use this branch with a
jnunemaker/httpartydatabase.HTTParty::Response::Headersis a good test class since it inherits fromNet::HTTPHeader:Checklist
ready-for-doc-reviewlabel there.