Skip to content

Remove @types/classnames package#3126

Merged
koesie10 merged 1 commit intomainfrom
koesie10/remove-types-classnames
Dec 13, 2023
Merged

Remove @types/classnames package#3126
koesie10 merged 1 commit intomainfrom
koesie10/remove-types-classnames

Conversation

@koesie10
Copy link
Copy Markdown
Member

classnames provides its own type definitions, so we do not need to have this installed.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

Base automatically changed from koesie10/npm-upgrade to main December 13, 2023 13:57
`classnames` provides its own type definitions, so we do not need to
have this installed.
@koesie10 koesie10 force-pushed the koesie10/remove-types-classnames branch from b5fa478 to 01f5a65 Compare December 13, 2023 14:33
@koesie10 koesie10 marked this pull request as ready for review December 13, 2023 14:36
@koesie10 koesie10 requested a review from a team as a code owner December 13, 2023 14:36
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@koesie10 koesie10 merged commit 3d65eca into main Dec 13, 2023
@koesie10 koesie10 deleted the koesie10/remove-types-classnames branch December 13, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants