Add a consistency check for the model editor#3141
Merged
Conversation
charisk
approved these changes
Dec 15, 2023
Contributor
charisk
left a comment
There was a problem hiding this comment.
LGTM!
I wouldn't even hide it behind a flag since it's only logging to the extension log. Those logs could be useful when debugging a user problem.
Member
Author
Good point, I've removed the feature flag. I ran into some incorrect checks for the Ruby model editor, so I've excluded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an internal consistency check for the model editor. This catches cases where the model editor thinks something is supported, but the model editor queries return that it it not supported.
This would for example have caught github/codeql#15089 without needing to manually check the query.
Checklist
ready-for-doc-reviewlabel there.