Skip to content

Add a consistency check for the model editor#3141

Merged
koesie10 merged 5 commits intomainfrom
koesie10/model-editor-consistency-check
Dec 15, 2023
Merged

Add a consistency check for the model editor#3141
koesie10 merged 5 commits intomainfrom
koesie10/model-editor-consistency-check

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds an internal consistency check for the model editor. This catches cases where the model editor thinks something is supported, but the model editor queries return that it it not supported.

This would for example have caught github/codeql#15089 without needing to manually check the query.

Screenshot 2023-12-14 at 12 09 40

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review December 14, 2023 12:19
@koesie10 koesie10 requested review from a team as code owners December 14, 2023 12:19
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I wouldn't even hide it behind a flag since it's only logging to the extension log. Those logs could be useful when debugging a user problem.

@koesie10
Copy link
Copy Markdown
Member Author

I wouldn't even hide it behind a flag since it's only logging to the extension log. Those logs could be useful when debugging a user problem.

Good point, I've removed the feature flag. I ran into some incorrect checks for the Ruby model editor, so I've excluded type models from being considered as supported. I've also updated the message to reference the model editor since it could now be shown to users if there is a bug in the queries or the model editor.

Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@koesie10 koesie10 merged commit 6cfa0a9 into main Dec 15, 2023
@koesie10 koesie10 deleted the koesie10/model-editor-consistency-check branch December 15, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants