You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This removes the immutable package since it's only used in 1 file and it's not really necessary in that file. I've rewritten the places where it's used in the simplest way possible (i.e. just replacing I.List with an array and I.Map with a standard Map). This removes approximately 175 KB from the bundled extension.js file.
Checklist
CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
Issues have been created for any UI or other user-facing changes made by this pull request.
[Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.
Shame there aren't any unit tests. Have you done any testing to confirm the change?
I haven't done any manual testing because I don't know how to exactly get this code to trigger and what I should be looking for. However, this is tested by some unit tests: test/unit-tests/log-scanner.test.ts.
Shame there aren't any unit tests. Have you done any testing to confirm the change?
I haven't done any manual testing because I don't know how to exactly get this code to trigger and what I should be looking for. However, this is tested by some unit tests: test/unit-tests/log-scanner.test.ts.
Ah I was looking for them in a join-order.test.ts or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
immutablepackage since it's only used in 1 file and it's not really necessary in that file. I've rewritten the places where it's used in the simplest way possible (i.e. just replacingI.Listwith an array andI.Mapwith a standardMap). This removes approximately 175 KB from the bundledextension.jsfile.Checklist
ready-for-doc-reviewlabel there.