Remove fallback behavior for database unbundle#3149
Merged
Conversation
The CodeQL CLI always supports the `database unbundle` command since 140d369 so we can remove the fallback behavior. There were some places which were not passing in the CodeQL CLI server, but these always have access to the CLI server, so this just passes them in. The only change in behavior (in terms of the fallback behavior) is in the `new-query.test.ts` test.
koesie10
force-pushed
the
koesie10/database-unbundle
branch
from
b29f502 to
14b2282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CodeQL CLI always supports the
database unbundlecommand since 140d369 so we can remove the fallback behavior.There were some places which were not passing in the CodeQL CLI server, but these always have access to the CLI server, so this just passes them in.
The only change in behavior (in terms of the fallback behavior) is in the
new-query.test.tstest.Checklist
ready-for-doc-reviewlabel there.