Skip to content

Add tests and test plan for GitHub database download#3160

Merged
koesie10 merged 2 commits intomainfrom
koesie10/github-databases-tests
Dec 21, 2023
Merged

Add tests and test plan for GitHub database download#3160
koesie10 merged 2 commits intomainfrom
koesie10/github-databases-tests

Conversation

@koesie10
Copy link
Copy Markdown
Member

This adds some simple test for promptGitHubRepositoryDownload that just check the logic within this method and mocks out all other calls since these are already tested separately. It also adds a step to the test plan for testing the basic functionality. Unfortunately, it's hard to test the update functionality without waiting for a new commit to land.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/github-databases-tests branch from 7e22632 to b3da120 Compare December 21, 2023 10:23
@koesie10 koesie10 marked this pull request as ready for review December 21, 2023 10:36
@koesie10 koesie10 requested review from a team as code owners December 21, 2023 10:36
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! It's a shame we have to expose functions just for testing, but the benefits of adding those tests far outweigh the drawbacks.

@koesie10 koesie10 merged commit f7c0d4d into main Dec 21, 2023
@koesie10 koesie10 deleted the koesie10/github-databases-tests branch December 21, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants