Skip to content

Add eslint-plugin-import#3173

Merged
koesie10 merged 1 commit intomainfrom
koesie10/eslint-plugin-import
Dec 22, 2023
Merged

Add eslint-plugin-import#3173
koesie10 merged 1 commit intomainfrom
koesie10/eslint-plugin-import

Conversation

@koesie10
Copy link
Copy Markdown
Member

It seems like we had some rules that disabled rules of this plugin, but we didn't actually have it installed. I've now installed it, used the recommended configuration, and removed our own disable rules. I've fixed any errors that this introduced.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

It seems like we had some rules that disabled rules of this plugin, but
we didn't actually have it installed. I've now installed it, used the
recommended configuration, and removed our own disable rules. I've fixed
any errors that this introduced.
@koesie10 koesie10 force-pushed the koesie10/eslint-plugin-import branch from e5f4ba3 to 7a7092d Compare December 21, 2023 16:02
@koesie10 koesie10 marked this pull request as ready for review December 21, 2023 16:16
@koesie10 koesie10 requested review from a team as code owners December 21, 2023 16:16
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koesie10 koesie10 merged commit 2b625c8 into main Dec 22, 2023
@koesie10 koesie10 deleted the koesie10/eslint-plugin-import branch December 22, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants