Skip to content

Add scripts for updating the Node and Chromium versions#3182

Merged
koesie10 merged 6 commits intomainfrom
koesie10/vscode-versions
Jan 3, 2024
Merged

Add scripts for updating the Node and Chromium versions#3182
koesie10 merged 6 commits intomainfrom
koesie10/vscode-versions

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Jan 2, 2024

This adds two scripts:

  • A script that will automatically set the correct Node.js versions based on the latest release of VS Code. It can be run using npx ts-node scripts/update-node-version.ts. I'll add a GitHub Actions workflow that runs this on a schedule in a follow-up PR so that a PR is automatically created when the Node.js version is updated.
  • A script that will automatically update the Chromium version based on the minimum supported version of VS Code. It can be run using npx ts-node scripts/update-chromium-version.ts. I'll add a GitHub Actions workflow in a follow-up PR that checks that this version is still current (as part of the main workflow).

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/vscode-versions branch from e7de62d to e3c7ab3 Compare January 2, 2024 15:06
@koesie10 koesie10 changed the title Add a script for updating the Node version Add a script for updating the Node and Chromium versions Jan 2, 2024
@koesie10 koesie10 force-pushed the koesie10/vscode-versions branch from e3c7ab3 to cf00f8f Compare January 2, 2024 15:28
@koesie10 koesie10 marked this pull request as ready for review January 2, 2024 16:02
@koesie10 koesie10 requested a review from a team as a code owner January 2, 2024 16:02
@koesie10 koesie10 changed the title Add a script for updating the Node and Chromium versions Add scripts for updating the Node and Chromium versions Jan 2, 2024
Copy link
Copy Markdown
Contributor

@norascheuch norascheuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change!

@koesie10 koesie10 merged commit cce0e14 into main Jan 3, 2024
@koesie10 koesie10 deleted the koesie10/vscode-versions branch January 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants