Add helper functions for suggestion box#3222
Merged
Conversation
This adds some helper functions that will be used for a suggestion box in the future. There is one helper function for highlighting part of a text case-insensitively. Another helper function will try to find followup options based on a list of tokens. The tests for these functions use access paths as input, but these functions are not intended to be specific to access paths. They can be used for any list of options/string.
koesie10
force-pushed
the
koesie10/suggest-box-helper-functions
branch
from
8e55529 to
7f730d2
Compare
shati-patel
approved these changes
Jan 15, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
This looks good! Thanks for the comprehensive tests too (I admit I haven't scrutinised them all in detail 🔍 😅 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some helper functions that will be used for a suggestion box in the future. There is one helper function for highlighting part of a text case-insensitively. Another helper function will try to find followup options based on a list of tokens.
The tests for these functions use access paths as input, but these functions are not intended to be specific to access paths. They can be used for any list of options/string.
Checklist
ready-for-doc-reviewlabel there.