Conversation
Base automatically changed from
koesie10/suggest-box-helper-functions
to
main
January 16, 2024 08:35
shati-patel
reviewed
Jan 17, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
I mainly played around with this in Storybook, since the code and tests look pretty comprehensive. One question, but otherwise LGTM!
Comment on lines
+22
to
+26
| const Input = styled(VSCodeTextField)` | ||
| width: 430px; | ||
|
|
||
| font-family: var(--vscode-editor-font-family); | ||
| `; |
Contributor
There was a problem hiding this comment.
Should this have a specified background colour too? When I tested in Storybook, the light themes looked like this:
Member
Author
There was a problem hiding this comment.
That seems to be a bug in the Storybook theme, it does work correctly when rendered in VS Code. You can see the same behavior in for example the Variant analysis story.
Contributor
There was a problem hiding this comment.
Ah, I see! That's annoying, but good to know that it's fine in VS Code 👌🏽
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a
SuggestBoxcomponent that can be used for a VS Code-like autocomplete on a list of options.Screen.Recording.2024-01-11.at.15.29.47.mov
This does not yet wire it up to anything, nor does it use the functions introduced in #3218. This component is not specific to access paths and could be used for any list of options with follow-up options.
The component uses
@floating-ui/reactto correctly position the suggestions and to implement accessibility correctly. Documentation about this can be found on the Floating UI docs. The example most like this implementation is the Autocomplete (combobox) example.To test this, you can use Storybook. There are also unit tests for most of the functionality of the component.
Checklist
ready-for-doc-reviewlabel there.