Merged
Conversation
robertbrignull
approved these changes
Jan 16, 2024
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM but obviously we paired on it, so I'll leave it up to you if you want to get another opinion.
shati-patel
approved these changes
Jan 16, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
One comment/question, otherwise LGTM
shati-patel
reviewed
Jan 16, 2024
…ager.ts Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
charisk
deleted the
charisk-robertbrignull/tidy-up-variant-analysis-commands
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with @robertbrignull.
The
codeQL.runVariantAnalysisandrunVariantAnalysisContextEditorcommands were both calling the same underlying code, making types a bit hard to follow. This makes the commands and types more explicit early onChecklist
N/A:
ready-for-doc-reviewlabel there.