Merged
Conversation
dbartol
force-pushed
the
dbartol/extensible-failure
branch
from
1febe44 to
d7f01dc
Compare
dbartol
added
the
Complexity: Low
cklin
reviewed
Jan 22, 2024
| public static CLI_VERSION_WITH_TRIM_CACHE = new SemVer("2.15.1"); | ||
|
|
||
| public static CLI_VERSION_WITH_EXTENSIBLE_PREDICATE_METADATA_IN_QLX = | ||
| new SemVer("2.16.1"); |
Contributor
There was a problem hiding this comment.
This constant is a bit misleading:
- Extensible predicate metadata is stored in a created qlpack (in
.packinfofiles), not in QLX - The CLI version that starts generating extensible predicate metadata is 2.16.0, not 2.16.1
Perhaps the constant name we want is something like CLI_VERSION_WITHOUT_MRVA_EXTENSIBLE_PREDICATE_HACK?
Contributor
Author
There was a problem hiding this comment.
I've renamed the constant and the function to better reflect the details, plus added a few comments.
cklin
approved these changes
Jan 22, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aeisenberg
approved these changes
Jan 22, 2024
Contributor
aeisenberg
left a comment
aeisenberg
left a comment
There was a problem hiding this comment.
Any problem merging this now so we can fix our integration tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer CLI versions preserve the metadata for extensible predicates in the compiled pack, so they no longer preserve queries that contain extensible predicates when creating a MRVA pack.
Fixes https://github.com/github/semmle-code/issues/48686