Skip to content

CodeQL model editor: Don't highlight row when clicking inside text box#3264

Merged
shati-patel merged 1 commit intomainfrom
shati-patel/select-row
Jan 22, 2024
Merged

CodeQL model editor: Don't highlight row when clicking inside text box#3264
shati-patel merged 1 commit intomainfrom
shati-patel/select-row

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

When you click the Type input boxes in the model editor (for Ruby), this shouldn't select/deselect the row:

image

(Inspired by c8d3127, which disables (de)selection when you click a dropdown)

Checklist

N/A: Feature-flagged for internal use for now.

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review January 22, 2024 16:03
@shati-patel shati-patel requested a review from a team as a code owner January 22, 2024 16:03
Copy link
Copy Markdown
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible to me

@shati-patel shati-patel merged commit 5664844 into main Jan 22, 2024
@shati-patel shati-patel deleted the shati-patel/select-row branch January 22, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants