Skip to content

Rename getQlPackPath to getQlPackFilePath#3265

Merged
charisk merged 1 commit intomainfrom
charisk/rename-getQlPackPath
Jan 22, 2024
Merged

Rename getQlPackPath to getQlPackFilePath#3265
charisk merged 1 commit intomainfrom
charisk/rename-getQlPackPath

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 22, 2024

I think this makes it clearer what this function does.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners January 22, 2024 16:37
shati-patel
shati-patel approved these changes Jan 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@charisk charisk enabled auto-merge (squash) January 22, 2024 16:38
@charisk charisk merged commit 5bb724b into main Jan 22, 2024
@charisk charisk deleted the charisk/rename-getQlPackPath branch January 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shati-patel shati-patel shati-patel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charisk @shati-patel