Skip to content

Rename queryPackDir -> targetPackPath#3284

Merged
charisk merged 1 commit intomainfrom
charisk/run-remote-query-renames
Jan 25, 2024
Merged

Rename queryPackDir -> targetPackPath#3284
charisk merged 1 commit intomainfrom
charisk/run-remote-query-renames

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Jan 25, 2024

I think this name makes the code a bit more readable and avoids the target pack being confused with the initial information we have around the queries and the pack they might be in.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner January 25, 2024 14:52
@charisk charisk merged commit 0e2c03f into main Jan 25, 2024
@charisk charisk deleted the charisk/run-remote-query-renames branch January 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants