Skip to content

Execute a distribution check when changing the CLI channel#3315

Merged
koesie10 merged 1 commit intomainfrom
koesie10/nightly-distribution-check
Feb 5, 2024
Merged

Execute a distribution check when changing the CLI channel#3315
koesie10 merged 1 commit intomainfrom
koesie10/nightly-distribution-check

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Feb 5, 2024

When you change the CLI channel setting, there is no distribution check, so the user doesn't get prompted to update their CLI to for example the latest nightly. This adds the setting as a setting that forces a distribution check so the user will get the prompt after changing the setting.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review February 5, 2024 12:29
@koesie10 koesie10 requested a review from a team as a code owner February 5, 2024 12:29
@koesie10 koesie10 requested a review from a team February 5, 2024 13:13
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@koesie10 koesie10 merged commit ad5ae27 into main Feb 5, 2024
@koesie10 koesie10 deleted the koesie10/nightly-distribution-check branch February 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants