Skip to content

Make query constraints for access paths query configurable#3318

Merged
koesie10 merged 1 commit intomainfrom
koesie10/access-paths-configurable-query-constraints
Feb 6, 2024
Merged

Make query constraints for access paths query configurable#3318
koesie10 merged 1 commit intomainfrom
koesie10/access-paths-configurable-query-constraints

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Feb 6, 2024

This makes the query constraints for the access paths query configurable since these can differ between the languages. It also updates the query constraint for the Ruby query from the access-path-suggestions tag to access-paths, since that is how the query was merged into CodeQL main.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 marked this pull request as ready for review February 6, 2024 13:26
@koesie10 koesie10 requested a review from a team as a code owner February 6, 2024 13:26
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 🚢

I guess this just means that we temporarily can't use the access paths query in the extension? (Since the "old" version used a different tag, and this new version doesn't have the correct output format for now)

@koesie10
Copy link
Copy Markdown
Member Author

koesie10 commented Feb 6, 2024

I guess this just means that we temporarily can't use the access paths query in the extension? (Since the "old" version used a different tag, and this new version doesn't have the correct output format for now)

Yes, but you'd have to have manually added the "old" query to your workspace, so the access path queries were probably not working for the majority of people anyway. You should still be able to use the old query by changing the access-path-suggestions tag to access-paths and not updating the CodeQL submodule to main. After #3320 is merged, you'd then need to remove the old query and update the submodule (or copy the new query).

@koesie10 koesie10 merged commit 6030137 into main Feb 6, 2024
@koesie10 koesie10 deleted the koesie10/access-paths-configurable-query-constraints branch February 6, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants