Skip to content

Use unknown instead of any where possible #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertbrignull merged 4 commits into from
Feb 12, 2024
Merged

Use unknown instead of any where possible #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
281242f
Use unknown in Disposable
robertbrignull Feb 6, 2024
e7adfdc
Use unknown for extension type
robertbrignull Feb 8, 2024
25f179c
Use unknown in QLDebugSession.customRequest
robertbrignull Feb 8, 2024
e5961f2
Use Record<string, unknown> for additionalRunQueryArgs
robertbrignull Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/common/disposable-object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Avoid explicitly referencing Disposable type in vscode.
// This file cannot have dependencies on the vscode API.
export interface Disposable {
dispose(): any;
dispose(): unknown;
}

export type DisposeHandler = (disposable: Disposable) => void;
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/common/vscode/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ export class ExtensionTelemetryListener
export let telemetryListener: ExtensionTelemetryListener | undefined;

export async function initializeTelemetry(
extension: Extension<any>,
extension: Extension<unknown>,
ctx: ExtensionContext,
): Promise<ExtensionTelemetryListener> {
if (telemetryListener !== undefined) {
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/debugger/debug-session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ export class QLDebugSession extends LoggingDebugSession implements Disposable {
protected customRequest(
command: string,
response: CodeQLProtocol.Response,
args: any,
args: unknown,
request?: Protocol.Request,
): void {
switch (command) {
Expand Down
4 changes: 2 additions & 2 deletions extensions/ql-vscode/src/query-server/query-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export class QueryRunner {
query: CoreQueryTarget,
additionalPacks: string[],
extensionPacks: string[] | undefined,
additionalRunQueryArgs: Record<string, any>,
additionalRunQueryArgs: Record<string, unknown>,
generateEvalLog: boolean,
outputDir: QueryOutputDir,
progress: ProgressCallback,
Expand Down Expand Up @@ -216,7 +216,7 @@ export class QueryRunner {
generateEvalLog: boolean,
additionalPacks: string[],
extensionPacks: string[] | undefined,
additionalRunQueryArgs: Record<string, any>,
additionalRunQueryArgs: Record<string, unknown>,
queryStorageDir: string,
id = `${basename(query.queryPath)}-${nanoid()}`,
templates: Record<string, string> | undefined,
Expand Down
2 changes: 1 addition & 1 deletion extensions/ql-vscode/src/query-server/run-queries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export async function compileAndRunQueryAgainstDatabaseCore(
generateEvalLog: boolean,
additionalPacks: string[],
extensionPacks: string[] | undefined,
additionalRunQueryArgs: Record<string, any>,
additionalRunQueryArgs: Record<string, unknown>,
outputDir: QueryOutputDir,
progress: ProgressCallback,
token: CancellationToken,
Expand Down