Use correct types where possible instead of any#3344
Merged
robertbrignull merged 8 commits intomainfrom Feb 12, 2024
Merged
Conversation
This endpoint actually has the correct type already. We could explicitly declare it as RestEndpointMethodTypes["codeScanning"]["listCodeqlDatabases"]["response"]["data"][0] but this seems unnecessary given how ugly that type is. If we just do nothing then typescript already computes the correct type for us.
robertbrignull
commented
Feb 12, 2024
| }); | ||
|
|
||
| const languages = response.data.map((db: any) => db.language); | ||
| const languages = response.data.map((db) => db.language); |
Contributor
Author
There was a problem hiding this comment.
In this case the correct type is inferred, so we're not just getting an implicit any type here.
shati-patel
approved these changes
Feb 12, 2024
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
Looks good, apart from the import [type] ... linter errors!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all the cases I could find where we are using
anybut there exists some other type we can use instead that doesn't involve changing anything else. If everything still compiles then this should be safe to do so.Checklist
ready-for-doc-reviewlabel there.