Skip to content

Avoid use of any in TelemetryListener#3346

Merged
robertbrignull merged 3 commits intomainfrom
robertbrignull/telemetry-unknown
Feb 13, 2024
Merged

Avoid use of any in TelemetryListener#3346
robertbrignull merged 3 commits intomainfrom
robertbrignull/telemetry-unknown

Conversation

@robertbrignull
Copy link
Copy Markdown
Contributor

In this PR:

  • Use string index notation to access the private field instead of casting to any. As far as I can tell this is the "intended way" to access private fields.
  • Uses the EnvelopeTelemetry type since it exists, instead of any.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@robertbrignull robertbrignull requested a review from a team February 12, 2024 15:45
@robertbrignull robertbrignull requested a review from a team as a code owner February 12, 2024 15:45
@robertbrignull robertbrignull merged commit 4ed6a7b into main Feb 13, 2024
@robertbrignull robertbrignull deleted the robertbrignull/telemetry-unknown branch February 13, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants