Remove cases from ResultsApp that seem to be impossible#3359
Merged
robertbrignull merged 2 commits intomainfrom Feb 14, 2024
Merged
Remove cases from ResultsApp that seem to be impossible#3359robertbrignull merged 2 commits intomainfrom
robertbrignull merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these cases for
resultsInfo === nullare impossible. The only two places whereupdateStateWithNewResultsInfois called both pass a non-null object forresultsInfo.I tried adding logging/exceptions/breakpoints into these cases and trying to hit them and I couldn't. I've also tried testing this branch and everything seems to still work perfectly fine.
Checklist
ready-for-doc-reviewlabel there.