Skip to content

Add progress ring in 'stop evaluation' button#3383

Merged
charisk merged 1 commit intomainfrom
charisk/stop-evaluation-progress
Feb 20, 2024
Merged

Add progress ring in 'stop evaluation' button#3383
charisk merged 1 commit intomainfrom
charisk/stop-evaluation-progress

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Feb 20, 2024

Adds a progress ring in to the "Stop evaluation" button to match the "designs".

stop-evaluation-progress.mov

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner February 20, 2024 16:28
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting a ring on it! 💃🏽 💍

@charisk charisk merged commit 0533dad into main Feb 20, 2024
@charisk charisk deleted the charisk/stop-evaluation-progress branch February 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants