Reduce repetition in MultipleModeledMethodsPanel.spec.tsx#3402
Merged
Conversation
koesie10
deleted the
koesie10/simplify-multiple-modeled-methods-panel-spec
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding or removing a prop from the
MultipleModeledMethodsPanelcomponent required adding/removing that prop from almost 40 separate places in this file (29 tests + 9rerendercalls = 38). This moves all of this to a simplerenderfunction that doesn't require any props, so now you only need to change it in 1 place (baseProps).Checklist
ready-for-doc-reviewlabel there.