Skip logging warning for multi-query variant analyses#3425
Merged
Conversation
shati-patel
approved these changes
Feb 29, 2024
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Nice, thanks! 💥
Side note, we now just show the first query, e.g.:
Variant analysis Implicit narrowing conversion in compound assignment submitted for processing
Variant analysis view loaded
It might be nice to remove that too (but possibly not worth it 😂)
Contributor
Author
Yeah, we have a few places where we show information from the first query rather than all of them. This is intentional while the multi-query support is still being built (and currently only in prototype phase). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-query variant analyses aren't currently tracked in the query history so the query history manager would log warnings when it would receive updates for them. This change stops logging warnings for those.
Checklist
N/A:
ready-for-doc-reviewlabel there.