Skip to content

Skip logging warning for multi-query variant analyses#3425

Merged
charisk merged 1 commit intomainfrom
charisk/skip-log
Feb 29, 2024
Merged

Skip logging warning for multi-query variant analyses#3425
charisk merged 1 commit intomainfrom
charisk/skip-log

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Feb 29, 2024

Multi-query variant analyses aren't currently tracked in the query history so the query history manager would log warnings when it would receive updates for them. This change stops logging warnings for those.

Checklist

N/A:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested a review from a team as a code owner February 29, 2024 13:26
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 💥

Side note, we now just show the first query, e.g.:

Variant analysis Implicit narrowing conversion in compound assignment submitted for processing
Variant analysis view loaded

It might be nice to remove that too (but possibly not worth it 😂)

@charisk
Copy link
Copy Markdown
Contributor Author

charisk commented Feb 29, 2024

Nice, thanks! 💥

Side note, we now just show the first query, e.g.:

Variant analysis Implicit narrowing conversion in compound assignment submitted for processing
Variant analysis view loaded

It might be nice to remove that too (but possibly not worth it 😂)

Yeah, we have a few places where we show information from the first query rather than all of them. This is intentional while the multi-query support is still being built (and currently only in prototype phase).

@charisk charisk merged commit a51bd76 into main Feb 29, 2024
@charisk charisk deleted the charisk/skip-log branch February 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants